[BEAM-7060] Cherry-pick #9562: Prefer inspect module over funcsigs #9591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3 with funcsigs installed, prefer inspect.{signature,Paramter}
over funcsigs equivalents.
Contributor
Author
|
+R: @udim |
udim
approved these changes
Sep 17, 2019
3 tasks
Member
|
@markflyhigh please let us know if the precommit failures are ok to ignore in the release branch. The docs task failure is being handled in #9620 |
Contributor
Author
|
I think the failure in Python Precommit can be ignore since it comes from Dataflow service side (once new container is built for this release, dataflow test should be unblocked). This change is fully tested against master so I think it's safe to cherry-pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3 with funcsigs installed, prefer inspect.{signature,Paramter}
over funcsigs equivalents.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.