Skip to content

Conversation

@Hannah-Jiang
Copy link
Contributor

@Hannah-Jiang Hannah-Jiang commented Sep 18, 2019

Use default tag which is latest instead of version.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@Hannah-Jiang
Copy link
Contributor Author

Run JavaPortabilityApi PreCommit

@Hannah-Jiang
Copy link
Contributor Author

R: @yifanzou

@yifanzou
Copy link
Contributor

The code looks good. A few questions: What would the default tag look like? Doesn't python images use the default tags?

@Hannah-Jiang
Copy link
Contributor Author

Hannah-Jiang commented Sep 18, 2019

The code looks good. A few questions: What would the default tag look like? Doesn't python images use the default tags?

Default tag is latest, which is defined here.
Python doesn't use default tag because it can read version from version.py.

@Hannah-Jiang
Copy link
Contributor Author

Run Python PreCommit

@yifanzou yifanzou merged commit 909bc5a into apache:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants