[BEAM-7962] Drop support for Flink 1.5 and 1.6 #9632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flink 1.9 is now released and Beam 2.17.0 is going to support it. Since the Flink community only supports the last two Flink releases, it is now time to drop at least 1.5 and 1.6. As a follow-up, we will get rid of Flink 1.5/1.6 specific workarounds, e.g. make use of Flink's preSnapshotBarrier in AbstractStreamOperator which removes the needs to buffer elements during a snapshot. Build time should decrease by several minutes.
Contributor
Author
|
Run Seed Job |
Contributor
Author
|
Run Flink ValidatesRunner |
Contributor
Author
|
Run Java Flink PortableValidatesRunner Batch |
Contributor
Author
|
Run Java Flink PortableValidatesRunner Streaming |
tweise
approved these changes
Sep 23, 2019
Contributor
tweise
left a comment
tweise
left a comment
There was a problem hiding this comment.
Nice, great to see the simplification this brings (and the reduction in CI burden).
dmvk
approved these changes
Sep 24, 2019
Member
dmvk
left a comment
dmvk
left a comment
There was a problem hiding this comment.
LGTM 👍 This is a great simplification!
Contributor
Author
|
Thank you for the reviews. |
mxm
added a commit
to mxm/beam
that referenced
this pull request
Sep 24, 2019
…OutputManager For Flink version <= 1.5 the Flink Runner had to buffer any elements which are emitted during a snapshot because the barrier has already been emitted. Flink version >= 1.6 provides a hook to execute an action before the snapshot barrier is emitted by the operator. We can remove the buffering in favor of finishing the current bundle in the DoFnOperator's prepareSnapshotPreBarrier. This had previously been deferred (apache#7940) until removal of Flink 1.5 (apache#9632).
This was referenced Oct 10, 2019
mxm
added a commit
to lyft/beam
that referenced
this pull request
Nov 1, 2019
…OutputManager For Flink version <= 1.5 the Flink Runner had to buffer any elements which are emitted during a snapshot because the barrier has already been emitted. Flink version >= 1.6 provides a hook to execute an action before the snapshot barrier is emitted by the operator. We can remove the buffering in favor of finishing the current bundle in the DoFnOperator's prepareSnapshotPreBarrier. This had previously been deferred (apache#7940) until removal of Flink 1.5 (apache#9632).
mxm
added a commit
to lyft/beam
that referenced
this pull request
Nov 1, 2019
…OutputManager For Flink version <= 1.5 the Flink Runner had to buffer any elements which are emitted during a snapshot because the barrier has already been emitted. Flink version >= 1.6 provides a hook to execute an action before the snapshot barrier is emitted by the operator. We can remove the buffering in favor of finishing the current bundle in the DoFnOperator's prepareSnapshotPreBarrier. This had previously been deferred (apache#7940) until removal of Flink 1.5 (apache#9632).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flink 1.9 is now released and Beam 2.17.0 is going to support it. Since the Flink community only supports the last two Flink releases, it is now time to drop at least 1.5 and 1.6.
As a follow-up, we will get rid of Flink 1.5/1.6 specific workarounds, e.g. make use of Flink's preSnapshotBarrier in AbstractStreamOperator which removes the needs to buffer elements during a snapshot.
Build time should decrease by several minutes.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.