Skip to content

Conversation

@iemejia
Copy link
Member

@iemejia iemejia commented Sep 23, 2019

Cherry pick of #9636 (done in parallel)
R: @pabloem
CC: @markflyhigh

@iemejia iemejia requested a review from pabloem September 23, 2019 15:22
@pabloem
Copy link
Member

pabloem commented Sep 23, 2019

Run Python PreCommit

@pabloem
Copy link
Member

pabloem commented Sep 23, 2019

Run Java_Examples_Dataflow PreCommit

@pabloem
Copy link
Member

pabloem commented Sep 23, 2019

LGTM. I've merged #9636 - I'll let the release manager merge this.

Copy link
Contributor

@markflyhigh markflyhigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@markflyhigh
Copy link
Contributor

Run Java_Examples_Dataflow PreCommit

@iemejia
Copy link
Member Author

iemejia commented Sep 24, 2019

Run Python PreCommit

@iemejia
Copy link
Member Author

iemejia commented Sep 24, 2019

Run Java_Examples_Dataflow PreCommit

1 similar comment
@markflyhigh
Copy link
Contributor

Run Java_Examples_Dataflow PreCommit

@pabloem
Copy link
Member

pabloem commented Sep 24, 2019

Run Python PreCommit

@markflyhigh
Copy link
Contributor

pydoc failure in Python Precommit will be fixed by cherry-pick #9654. We can ignore it since all test passed.

@markflyhigh
Copy link
Contributor

Run Java_Examples_Dataflow PreCommit

@markflyhigh markflyhigh merged commit 8884112 into apache:release-2.16.0 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants