[BEAM-8509] TestPortableRunner uses JobServerDriver interface #9914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, due to Java language limitations we cannot define fromParams as an abstract static method. But at least start and stop are enforced by the type system now.
Author
|
Run Java Flink PortableValidatesRunner Batch |
mxm
approved these changes
Oct 29, 2019
| try { | ||
| jobServerDriver = | ||
| InstanceBuilder.ofType(jobServerDriverClass) | ||
| .fromFactoryMethod("fromParams") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, due to Java language limitations we cannot define fromParams as an abstract static method. But at least start and stop are enforced by the type system now.
R: @tweise @mxm
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.