(WIP) Issue #1380 Fix logic of RRQuorumCoverageSet.checkCovered #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in RRQuorumCoverageSet.checkCovered track the ok responses and then check if it is lesser than ackQuorumNum before returning false.
Contributor
|
I think this issue is obsolete, at least for 4.11. |
Contributor
|
check #2333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
in RRQuorumCoverageSet.checkCovered track the ok responses
and then check if it is lesser than ackQuorumNum before
returning false.
** this is WIP. There are failing testcases because of this change. Will fix those testcases based on this PR code review**
Master Issue: #1380