Limit maven http connection pool TTL in Github flows #2460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "Tranfer failed for https://repo.maven.apache.org/... .jar: Connection reset" type of failures in Github Flows environment Set maven.wagon.httpconnectionManager.ttlSeconds to 25 seconds. Besides this, set maven.wagon.http.retryHandler.count to 3 retries. https://issues.apache.org/jira/browse/WAGON-545 contains a recommendation "Azure users shall set the TTL to 240 seconds or less." The reason for the 25 second TTL is to ensure that it's shorter than any common firewall or NAT timeout. Some NATs have a 30 second idle timeout although that is very rare. There shouldn't be harm in using the 25 second TTL since the connection pool will be able to pool connections well with a 25 second TTL. The documentation for maven.wagon.httpconnectionManager.ttlSeconds is available in the source code: https://github.com/apache/maven-wagon/blob/wagon-3.4.1/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L297-L305 Documentation for maven.wagon.http.retryHandler.count is in https://maven.apache.org/wagon/wagon-providers/wagon-http/ "Any retry handler can only react to exceptions when executing the request and receiving the response head. It will not salvage in-flight failures of ongoing response body streams." Therefore the retry count setting is a bit different than expected. WAGON-545 explains that ConnectionExceptions aren't part of the retried exceptions by default. If such issues become problems, it's possible to configure the retry handler in a more fine grained way.
Contributor
|
Awesome, thanks and welcome @lhotari ! |
Member
Author
|
@eolivelli @Ghatage Thank you. I'm happy to join the BK community. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes "Transfer failed for https://repo.maven.apache.org/...
.jar: Connection reset" type of failures in Github Flows environment such as
Changes
Set
maven.wagon.httpconnectionManager.ttlSecondsto 25 seconds.Besides this, set
maven.wagon.http.retryHandler.countto 3 retries.https://issues.apache.org/jira/browse/WAGON-545
contains a recommendation "Azure users shall set the TTL to 240 seconds or less."
The reason for the 25 second TTL is to ensure that it's shorter than any common
firewall or NAT timeout. Some NATs have a 30 second idle timeout although
that is very rare. There shouldn't be harm in using the 25 second TTL since
the connection pool will be able to pool connections well with a 25 second TTL.
The documentation for
maven.wagon.httpconnectionManager.ttlSecondsisavailable in the source code:
https://github.com/apache/maven-wagon/blob/wagon-3.4.1/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L297-L305
Documentation for
maven.wagon.http.retryHandler.countis inhttps://maven.apache.org/wagon/wagon-providers/wagon-http/
"Any retry handler can only react to exceptions when executing the request and
receiving the response head. It will not salvage in-flight failures of ongoing
response body streams." Therefore the retry count setting is a bit
different than expected. WAGON-545 explains that ConnectionExceptions
aren't part of the retried exceptions by default. If such issues become
problems, it's possible to configure the retry handler in a more fine
grained way.
This is similar to the change made in Pulsar: apache/pulsar#8386