ISSUE-2640: BP-43: Fix test cases that fail when running with gradle #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sursingh
force-pushed
the
fix-gradle-test
branch
2 times, most recently
from
54d6e7e to
d57dd84
Compare
sursingh
force-pushed
the
fix-gradle-test
branch
from
d57dd84 to
eed2fc9
Compare
merlimat
approved these changes
Apr 15, 2021
hsaputra
pushed a commit
that referenced
this pull request
Apr 19, 2021
### Motivation After deleting many ledgers, seeking to the end of the RocksDB metadata can take a long time and trigger timeouts upstream. Address this by improving the seek logic as well as compacting out tombstones in situations where we've just deleted many entries. This affects the entry location index and the ledger metadata index. Reviewers: Andrey Yegorov, Prashant Kumar This closes #2686 from mauricebarnum/rocksdb-tombstones and squashes the following commits: c029968 [Maurice Barnum] Partially compact RocksDB after removing deleted ledgers 0be68a1 [Maurice Barnum] KeyValueStorageRocksDB bounded key iterator: use RocksDB upper bound 0c5ef8f [Maurice Barnum] KeyValueStorageRocksDB.getFloor() - reimplement to avoid two seeks 114cc73 [Maurice Barnum] update rocksdb to 6.16.4 f489a05 [Surinder Singh] Fix test cases using gradle build (#2689) 9256dba [Lari Hotari] Add current ip address, long hostname and short hostname to /etc/hosts (#2688) f1a1f12 [Surinder Singh] staging and setting up vote for release candidates (#2681) 2dd4afe [Prashant Kumar] ISSUE-2640: BP-43: Gradle integration with RAT plugin (#2683) 79768fe [Jack Vanlightly] ISSUE #2615: Fix for invalid ensemble issue during ledger recovery 646e590 [Prashant Kumar] ISSUE #2640: BP-43 integrate gradle javadoc plugin d70153f [hangc0276] Update documentation with default value for openLedgerRereplicationGracePeriod config option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate bookkeeper build to gradle. Some test cases were failing while running test with gradle
Changes