Turn Bookie into an interface #2717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
reviewed
May 22, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
very good.
I know that this is a "draft", but I left a couple of comments
thanks for this contribution
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
Outdated
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
Outdated
Show resolved
Hide resolved
Bookie was previously a concrete class that was used and abused all over the place, especially in tests. A classic example of the God object antipattern. The extensive use in tests, resulted in test cases which spin up many instances of the whole system, which is very heavy and very slow, especially when trying to unit tests a particular feature. This change is the first step to resolving this situation. Bookie is now an interface, implemented by BookieImpl. Subsequent changes will break out parts of the interface, cleanup calls and add dependency injection.
pkumar-singh
force-pushed
the
merge_back_to_oss
branch
from
c9c36ee to
db69026
Compare
Contributor
|
Will merge this by EOD if no more comment or concern. Thank you |
merlimat
approved these changes
May 25, 2021
Sunny-Island
pushed a commit
to Sunny-Island/bookkeeper
that referenced
this pull request
Jun 2, 2021
### Motivation Bookie was previously a concrete class that was used and abused all over the place, especially in tests. A classic example of the God object antipattern. The extensive use in tests, resulted in test cases which spin up many instances of the whole system, which is very heavy and very slow, especially when trying to unit tests a particular feature. This change is the first step to resolving this situation. Bookie is now an interface, implemented by BookieImpl. Subsequent changes will break out parts of the interface, cleanup calls and add dependency injection. Reviewers: Matteo Merli <mmerli@apache.org>, Andrey Yegorov, Henry Saputra <hsaputra@apache.org>, Enrico Olivelli <eolivelli@gmail.com> This closes apache#2717 from pkumar-singh/merge_back_to_oss and squashes the following commits: 3edee49 [Prashant] Replace SettableFuture with CompletableFuture db69026 [Ivan Kelly] Turn Bookie into an interface
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation Bookie was previously a concrete class that was used and abused all over the place, especially in tests. A classic example of the God object antipattern. The extensive use in tests, resulted in test cases which spin up many instances of the whole system, which is very heavy and very slow, especially when trying to unit tests a particular feature. This change is the first step to resolving this situation. Bookie is now an interface, implemented by BookieImpl. Subsequent changes will break out parts of the interface, cleanup calls and add dependency injection. Reviewers: Matteo Merli <mmerli@apache.org>, Andrey Yegorov, Henry Saputra <hsaputra@apache.org>, Enrico Olivelli <eolivelli@gmail.com> This closes apache#2717 from pkumar-singh/merge_back_to_oss and squashes the following commits: 3edee49 [Prashant] Replace SettableFuture with CompletableFuture db69026 [Ivan Kelly] Turn Bookie into an interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bookie was previously a concrete class that was used and abused all
over the place, especially in tests. A classic example of the God
object antipattern. The extensive use in tests, resulted in test cases
which spin up many instances of the whole system, which is very heavy
and very slow, especially when trying to unit tests a particular
feature.
This change is the first step to resolving this situation. Bookie is
now an interface, implemented by BookieImpl. Subsequent changes will
break out parts of the interface, cleanup calls and add dependency
injection.