Support specifying bookie http port as a command argument #2769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
requested changes
Aug 23, 2021
Contributor
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
LGTM, I'd like to add short-hand option name as the other options
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java
Outdated
Show resolved
Hide resolved
Contributor
|
@nicoloboschi PTAL |
|
@sijie can you merge? |
zymap
approved these changes
Feb 9, 2022
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
### Motivation I was trying to start multiple bookies locally and found it's a bit inconvenient to specify different http ports for different bookies. ### Changes Add a command-line argument `httpport` to the bookie command to support specifying bookie http port from the command line.
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation I was trying to start multiple bookies locally and found it's a bit inconvenient to specify different http ports for different bookies. ### Changes Add a command-line argument `httpport` to the bookie command to support specifying bookie http port from the command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was trying to start multiple bookies locally and found it's a bit inconvenient to specify different http ports for different bookies.
Changes
Add a command-line argument
httpportto the bookie command to support specifying bookie http port from the command line.