replication stat num-under-replicated-ledgers changed as with the pro… #2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@eolivelli PTAL |
nicoloboschi
requested changes
Sep 23, 2021
Contributor
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
LGTM, minor comments here
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
Outdated
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@nicoloboschi PTAL |
dlg99
requested changes
Sep 23, 2021
Contributor
dlg99
left a comment
dlg99
left a comment
There was a problem hiding this comment.
I am not convinced that it solves the problem as you outlined it (see my comment on the review) + the PR needs a unit test.
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
replication-stats-num-under-replicated-ledgers
branch
from
431f26f to
7d985c8
Compare
dlg99
approved these changes
Sep 28, 2021
Contributor
fyi: https://bookkeeper.apache.org/community/coding_guide/ and https://bookkeeper.apache.org/community/contributing/#optional-ide-setup for checkstyle configuration |
eolivelli
approved these changes
Oct 5, 2021
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
replication-stats-num-under-replicated-ledgers
branch
2 times, most recently
from
fc639a2 to
11d6119
Compare
added 2 commits
January 19, 2022 20:25
…cess of replication
gaozhangmin
force-pushed
the
replication-stats-num-under-replicated-ledgers
branch
from
6f4ee21 to
7f0b333
Compare
Contributor
Author
|
@eolivelli PTAL again, It has been for a lone time |
Contributor
Author
|
@zymap PTAL |
Contributor
Author
|
rerun failure checks |
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
…cess of replication Motivation Now ReplicationStats numUnderReplicatedLedger registers when `publishSuspectedLedgersAsync`, but its value doesn't decrease as with the ledger replicated successfully, We cannot know the progress of replication from the stat. Changes registers a notifyUnderReplicationLedgerChanged when auditor starts. numUnderReplicatedLedger value will decrease when the ledger path under replicate deleted. Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <None> This closes apache#2805 from gaozhangmin/replication-stats-num-under-replicated-ledgers
hangc0276
reviewed
Aug 17, 2023
| } | ||
| }; | ||
| try { | ||
| zkc.addWatch(urLedgerPath, w, AddWatchMode.PERSISTENT_RECURSIVE); |
Contributor
There was a problem hiding this comment.
It will register a lot of watcher on Zookeeper
| public void operationComplete(int rc, Void result) { | ||
| Iterator<UnderreplicatedLedger> underreplicatedLedgersInfo = ledgerUnderreplicationManager | ||
| .listLedgersToRereplicate(null); | ||
| underReplicatedLedgersGuageValue.set(Iterators.size(underreplicatedLedgersInfo)); |
Contributor
There was a problem hiding this comment.
The Iterators.size will iterate the whole Znodes in an under-replicated path which brings heavy pressure on Zookeeper and lead to dead lock.
Member
Agree, I think we can revert it. |
4 tasks
Contributor
|
This PR introduced a deadlock described: apache/pulsar#21010 |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…cess of replication Motivation Now ReplicationStats numUnderReplicatedLedger registers when `publishSuspectedLedgersAsync`, but its value doesn't decrease as with the ledger replicated successfully, We cannot know the progress of replication from the stat. Changes registers a notifyUnderReplicationLedgerChanged when auditor starts. numUnderReplicatedLedger value will decrease when the ledger path under replicate deleted. Reviewers: Nicolò Boschi <boschi1997@gmail.com>, Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <None> This closes apache#2805 from gaozhangmin/replication-stats-num-under-replicated-ledgers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now ReplicationStats numUnderReplicatedLedger registers when
publishSuspectedLedgersAsync, but its value doesn't decrease as with the ledger replicated successfully, We cannot know the progress of replication from the stat.Changes
registers a notifyUnderReplicationLedgerChanged when auditor starts. numUnderReplicatedLedger value will decrease when the ledger path under replicate deleted.