Skip to content

Add ensemble check to over-replicated ledger GC #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zymap merged 4 commits into from
Oct 22, 2021
Merged

Add ensemble check to over-replicated ledger GC #2813

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f5f600
Add pre-check to over-replicated ledger GC
shustsud Oct 5, 2021
c316900
Fixed log
shustsud Oct 7, 2021
cb3452b
Fixed pre-check
shustsud Oct 11, 2021
728fbba
Moved readLedgerMetadata
shustsud Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 29 additions & 18 deletions ...per-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,12 @@ private Set<Long> removeOverReplicatedledgers(Set<Long> bkActiveledgers, final G

for (final Long ledgerId : bkActiveledgers) {
try {
// check if the ledger is being replicated already by the replication worker
if (lum.isLedgerBeingReplicated(ledgerId)) {
// check ledger ensembles before creating lock nodes.
// this is to reduce the number of lock node creations and deletions in ZK.
// the ensemble check is done again after the lock node is created.
// also, check if the ledger is being replicated already by the replication worker
Versioned<LedgerMetadata> preCheckMetadata = ledgerManager.readLedgerMetadata(ledgerId).get();
if (!isNotBookieIncludedInLedgerEnsembles(preCheckMetadata) || lum.isLedgerBeingReplicated(ledgerId)) {
latch.countDown();
continue;
}
Expand All @@ -245,23 +249,12 @@ private Set<Long> removeOverReplicatedledgers(Set<Long> bkActiveledgers, final G
.whenComplete((metadata, exception) -> {
try {
if (exception == null) {
// do not delete a ledger that is not closed, since the ensemble might
// change again and include the current bookie while we are deleting it
if (!metadata.getValue().isClosed()) {
return;
if (isNotBookieIncludedInLedgerEnsembles(metadata)) {
// this bookie is not supposed to have this ledger,
// thus we can delete this ledger now
overReplicatedLedgers.add(ledgerId);
garbageCleaner.clean(ledgerId);
}
SortedMap<Long, ? extends List<BookieId>> ensembles =
metadata.getValue().getAllEnsembles();
for (List<BookieId> ensemble : ensembles.values()) {
// check if this bookie is supposed to have this ledger
if (ensemble.contains(selfBookieAddress)) {
return;
}
}
// this bookie is not supposed to have this ledger,
// thus we can delete this ledger now
overReplicatedLedgers.add(ledgerId);
garbageCleaner.clean(ledgerId);
}
} finally {
semaphore.release();
Expand Down Expand Up @@ -302,4 +295,22 @@ private static MetadataBookieDriver instantiateMetadataDriver(ServerConfiguratio
}
}

private boolean isNotBookieIncludedInLedgerEnsembles(Versioned<LedgerMetadata> metadata) {
// do not delete a ledger that is not closed, since the ensemble might
// change again and include the current bookie while we are deleting it
if (!metadata.getValue().isClosed()) {
return false;
}

SortedMap<Long, ? extends List<BookieId>> ensembles =
metadata.getValue().getAllEnsembles();
for (List<BookieId> ensemble : ensembles.values()) {
// check if this bookie is supposed to have this ledger
if (ensemble.contains(selfBookieAddress)) {
return false;
}
}

return true;
}
}