Use OutOfMemoryPolicy when the direct memory is insufficient when reading the entry in ReadCache #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding the entry in ReadCache
Member
Author
|
@merlimat @eolivelli @dlg99 @codelipenghui PTAL, thanks. |
Member
Author
Contributor
|
closed/reopened to re-trigger merge/CI |
dlg99
approved these changes
Feb 14, 2022
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
…ding the entry in ReadCache ### Motivation Original PR: apache#1755, It should be that this PR forgot to modify the memory application method. When the direct memory is insufficient, it does not fall back to the jvm memory, and the bookie hangs directly.   ### Changes Use `OutOfMemoryPolicy` when the direct memory is insufficient when reading the entry in `ReadCache`. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <None> This closes apache#2836 from wenbingshen/useOutOfMemoryPolicyInReadCache
wolfstudy
pushed a commit
to wolfstudy/bookkeeper
that referenced
this pull request
Aug 2, 2022
…ding the entry in ReadCache ### Motivation Original PR: apache#1755, It should be that this PR forgot to modify the memory application method. When the direct memory is insufficient, it does not fall back to the jvm memory, and the bookie hangs directly.   ### Changes Use `OutOfMemoryPolicy` when the direct memory is insufficient when reading the entry in `ReadCache`. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <None> This closes apache#2836 from wenbingshen/useOutOfMemoryPolicyInReadCache (cherry picked from commit f19544b)
wolfstudy
pushed a commit
to wolfstudy/bookkeeper
that referenced
this pull request
Aug 2, 2022
…e request !7) Cherry pick 4.15 bug changes to repo 1. cherry pick some 4.15.0 changes - apache#2962 - apache#2836 2. Bump new bookie version to 4.14.4.220419-SNAPSHOT
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…ding the entry in ReadCache ### Motivation Original PR: apache#1755, It should be that this PR forgot to modify the memory application method. When the direct memory is insufficient, it does not fall back to the jvm memory, and the bookie hangs directly.   ### Changes Use `OutOfMemoryPolicy` when the direct memory is insufficient when reading the entry in `ReadCache`. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Andrey Yegorov <None> This closes apache#2836 from wenbingshen/useOutOfMemoryPolicyInReadCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Original PR: #1755,
It should be that this PR forgot to modify the memory application method.
When the direct memory is insufficient, it does not fall back to the jvm memory, and the bookie hangs directly.
Changes
Use
OutOfMemoryPolicywhen the direct memory is insufficient when reading the entry inReadCache.