ISSUE #2835: BP-44 Addition of thread-scoped OpStatsLogger and Counter #2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanlightly
force-pushed
the
thread-scoped-stats
branch
4 times, most recently
from
94d77ac to
1d732ba
Compare
The Counter and OpStatsLogger have new variants that add threadPool and thread labels to their metrics. These new variants can be obtained via new methods in the StatsLogger interface.
Vanlightly
force-pushed
the
thread-scoped-stats
branch
from
1d732ba to
79645fa
Compare
eolivelli
requested changes
Oct 22, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
very good, I left some comments
...ics-provider/src/main/java/org/apache/bookkeeper/stats/prometheus/PrometheusStatsLogger.java
Outdated
Show resolved
Hide resolved
bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/ThreadRegistry.java
Show resolved
Hide resolved
bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/ThreadRegistry.java
Outdated
Show resolved
Hide resolved
bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/ThreadRegistry.java
Outdated
Show resolved
Hide resolved
merlimat
approved these changes
Oct 22, 2021
dlg99
approved these changes
Oct 22, 2021
Contributor
Author
|
@eolivelli can you PTAL, I can follow up with another PR with the new and modified metrics. |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…Counter (apache#2839) * Addition of thread-scoped stats The Counter and OpStatsLogger have new variants that add threadPool and thread labels to their metrics. These new variants can be obtained via new methods in the StatsLogger interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of BP-44, some metrics can provide more insight with the addition of labels that allow for drill-down by thread pool and thread ordinal.
Changes
This PR does not include the usage of these new thread-scoped variants as so is completely backwards compatible.
Master Issue: #2835