Skip to content

Conversation

@equanz
Copy link
Contributor

@equanz equanz commented Oct 26, 2021

Motivation

Fixes #2854 issue

Changes

  • Use correct lockpath at ZkLedgerUnderreplicationManager#acquireUnderreplicatedLedger
  • Store Lock to heldLocks at ZkLedgerUnderreplicationManager#acquireUnderreplicatedLedger
    • for safety, I introduce Optional to Lock#ledgerZNodeVersion

…plicationManager#acquireUnderreplicatedLedger
@dlg99 dlg99 requested a review from merlimat October 26, 2021 20:51
@equanz
Copy link
Contributor Author

equanz commented Oct 29, 2021

@zymap Thank you for being release manager.
https://mail-archives.apache.org/mod_mbox/bookkeeper-dev/202110.mbox/%3CCALmzCGX30fopqjUqz5ztVi7jsqY2Lj%3D_1hoGL7t99D%3Ds%2B53YMg%40mail.gmail.com%3E

I think we should fix the issue #2854 before including the #2833 commit to the next version. Could you please take a look?

@merlimat merlimat merged commit 4b0f0fa into apache:master Nov 2, 2021
merlimat pushed a commit that referenced this pull request Nov 2, 2021
@equanz equanz deleted the fix_underreplicated_lock branch November 2, 2021 07:10
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When ScanAndCompareGarbageCollector#removeOverReplicatedledgers is called, underreplicated ledger locks are still acquired.

2 participants