Skip to content

Conversation

@zymap
Copy link
Member

@zymap zymap commented Oct 28, 2021

Motivation

Release note for 4.14.3


PLEASE MERGE #2863 BEFORE MERGING THIS PR

title: Apache BookKeeper 4.14.3 Release Notes
---

Release 4.14.3 fixes an issue with Prometheus metrics that was
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which issue is that? It is not obvious the list below. #2718 was included in 4.14.1, was there something else?
If it deserves being highlighted in the release notes I think it should have a little bit more info describing the problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the release includes many more fixes, so maybe word it as "Release X includes multiple stability, performance, and security fixes along with the fix for Prometheus metrics regression. The regression introduced in release Y resulted in ."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I am not noticed that. It's generated from scripts and I only changed the Highlights. I will fix that. Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. PTAL

@zymap
Copy link
Member Author

zymap commented Nov 10, 2021

@eolivelli @dlg99 Please take a look at this. The vote has been closed. I need to merge this PR. #2863 need to merge before merging this. Thank you!

Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one spelling correction

Co-authored-by: Andrey Yegorov <8622884+dlg99@users.noreply.github.com>
@zymap zymap merged commit 082a521 into apache:master Nov 11, 2021
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
### Motivation

Release note for 4.14.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants