Skip to content

Conversation

@ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Nov 25, 2021

Signed-off-by: Eric Shen ericshenyuhao@outlook.com

Descriptions of the changes in this PR:

Motivation

The description of bin/bookkeeper autorecovery is wrong, it won't start in daemon.

Changes

  • Changed the description in bookkeeper shell
  • Update the doc

In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
@dlg99 dlg99 added this to the 4.15.0 milestone Feb 14, 2022
@dlg99 dlg99 merged commit c5a5167 into apache:master Feb 14, 2022
@ericsyh ericsyh deleted the fix-bk-cli branch February 15, 2022 01:58
StevenLuMT pushed a commit to StevenLuMT/bookkeeper that referenced this pull request Feb 16, 2022
Signed-off-by: Eric Shen <ericshenyuhaooutlook.com>

Descriptions of the changes in this PR:


### Motivation

The description of `bin/bookkeeper autorecovery` is wrong, it won't start in daemon.

### Changes

* Changed the description in bookkeeper shell
* Update the doc



Reviewers: Yong Zhang <zhangyong1025.zy@gmail.com>

This closes apache#2910 from ericsyh/fix-bk-cli
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Signed-off-by: Eric Shen <ericshenyuhaooutlook.com>

Descriptions of the changes in this PR:


### Motivation

The description of `bin/bookkeeper autorecovery` is wrong, it won't start in daemon.

### Changes

* Changed the description in bookkeeper shell
* Update the doc



Reviewers: Yong Zhang <zhangyong1025.zy@gmail.com>

This closes apache#2910 from ericsyh/fix-bk-cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants