Skip to content

Make sure the LedgerHandle close callback can be completed when encounter exception #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eolivelli merged 2 commits into from
Jul 29, 2022
Merged

Make sure the LedgerHandle close callback can be completed when encounter exception #2913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86b1e90
Make sure the LedgerHandle close callback can be completed when encou…
codelipenghui Nov 26, 2021
959f3e3
Address comment.
codelipenghui Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,12 @@ public void safeRun() {

// error out all pending adds during closing, the callbacks shouldn't be
// running under any bk locks.
errorOutPendingAdds(rc, pendingAdds);
try {
errorOutPendingAdds(rc, pendingAdds);
} catch (Throwable e) {
closePromise.completeExceptionally(e);
Copy link
Member

@zymap zymap Nov 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there has an exception, do we still need to do the tearDownWriteHandleState() and MetadataUpdateLoop operations?

Copy link
Contributor

@hangc0276 hangc0276 Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it still needs the following operations. Catch this exception just to ensure the closePromise can complete.

Copy link
Contributor

@eolivelli eolivelli Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't "completeExceptionally" or "complete" the closePromise twice

return;
}

if (prevHandleState != HandleState.CLOSED) {
if (LOG.isDebugEnabled()) {
Expand Down