Skip update entryLogMetaMap if not modified #2964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
rerun failure checks |
Contributor
Author
|
@rdhabalia @eolivelli @zymap Please help take a look, thanks. |
Contributor
Author
|
rerun failure checks |
zymap
approved these changes
Dec 27, 2021
rdhabalia
approved these changes
Jan 5, 2022
|
|
||
| private void removeIfLedgerNotExists(EntryLogMetadata meta) throws EntryLogMetadataMapException { | ||
| private boolean removeIfLedgerNotExists(EntryLogMetadata meta) throws EntryLogMetadataMapException { | ||
| AtomicBoolean modified = new AtomicBoolean(false); |
Contributor
There was a problem hiding this comment.
you can use light weight MutableBoolean instead AtomicBoolean
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
### Motivation After we support RocksDB backend entryMetaMap, we should avoid updating the entryMetaMap if unnecessary. In `doGcEntryLogs` method, it iterate through the entryLogMetaMap and update the meta if ledgerNotExists. We should check whether the meta has been modified in `removeIfLedgerNotExists`. If not modified, we can avoid update the entryLogMetaMap. ### Modification 1. Add a flag to represent whether the meta has been modified in `removeIfLedgerNotExists` method. If not, skip update the entryLogMetaMap.
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation After we support RocksDB backend entryMetaMap, we should avoid updating the entryMetaMap if unnecessary. In `doGcEntryLogs` method, it iterate through the entryLogMetaMap and update the meta if ledgerNotExists. We should check whether the meta has been modified in `removeIfLedgerNotExists`. If not modified, we can avoid update the entryLogMetaMap. ### Modification 1. Add a flag to represent whether the meta has been modified in `removeIfLedgerNotExists` method. If not, skip update the entryLogMetaMap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After we support RocksDB backend entryMetaMap, we should avoid updating the entryMetaMap if unnecessary.
In
doGcEntryLogsmethod, it iterate through the entryLogMetaMap and update the meta if ledgerNotExists. We should check whether the meta has been modified inremoveIfLedgerNotExists. If not modified, we can avoid update the entryLogMetaMap.Modification
removeIfLedgerNotExistsmethod. If not, skip update the entryLogMetaMap.