Forced the same version of guava (plus upgraded it); fixed deprecations etc. #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
approved these changes
Jan 27, 2022
Contributor
|
please fix the conflicts |
Contributor
Author
|
@eolivelli I rebased it, I believe we'll get conflicts in either this or netty update PR, depends on which one is merged first. |
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
…ns etc. ### Motivation Older versions of guava (w/CVEs) used in some subprojects ### Changes Forced the same version of guava; fixed deprecation problems (murmur3_32) and compilation problems (checkArgument). checkArgument cannot be statically imported because there are now overrides of it; checkstyle was not very cooperative so I had to remove the import altogether. Then updated the guava version to match one in Pulsar. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Nicolò Boschi <boschi1997@gmail.com> This closes apache#3010 from dlg99/gradle-guava
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…ns etc. ### Motivation Older versions of guava (w/CVEs) used in some subprojects ### Changes Forced the same version of guava; fixed deprecation problems (murmur3_32) and compilation problems (checkArgument). checkArgument cannot be statically imported because there are now overrides of it; checkstyle was not very cooperative so I had to remove the import altogether. Then updated the guava version to match one in Pulsar. Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Nicolò Boschi <boschi1997@gmail.com> This closes apache#3010 from dlg99/gradle-guava
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Older versions of guava (w/CVEs) used in some subprojects
Changes
Forced the same version of guava; fixed deprecation problems (murmur3_32) and compilation problems (checkArgument).
checkArgument cannot be statically imported because there are now overrides of it; checkstyle was not very cooperative so I had to remove the import altogether.
Then updated the guava version to match one in Pulsar.