Auditor should get the LegdgerManagerFactory from the client instance #3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlg99
approved these changes
Jan 26, 2022
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
…apache#3011) * Auditor should get the LegdgerManagerFactory from the client instance * Removed unused import
merlimat
added a commit
that referenced
this pull request
Mar 21, 2022
…#3011) * Auditor should get the LegdgerManagerFactory from the client instance * Removed unused import
4 tasks
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…apache#3011) * Auditor should get the LegdgerManagerFactory from the client instance * Removed unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The auditor cannot assume to have a Zookeeper based
LedgerManagerFactory. Instead, the BK client already has a instance of the factory that we can reuse.Additionally, the code was leaking the factory instance which was supposed to get closed.