[build] do not run spotbugsTest by default #3017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Jan 27, 2022
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
We should run spotbugs by default.
This way when you build the project after making some changes you are sure that you are still over the quality bar that we set for the project.
Spotbugs must always pass.
Contributor
Author
|
I'm removing it only for the test classes |
eolivelli
approved these changes
Jan 27, 2022
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
thanks
My Gradle fu is so weak :-)
LGTM
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
spotbugsTestfails on a few submodules.Run spotbugs against test files is useless and slow down development.
We can just skip it by default without having to specify
-x spotbugsTestChanges
Skip
spotbugsTestby default