Fix performance issues to avoid unnecessary loops. #3030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@merlimat @eolivelli @dlg99 @nicoloboschi PTAL :) |
eolivelli
approved these changes
Feb 9, 2022
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
but this is not a big deal, as "allowedRoles" is usually a very small list, like 1 entry
Member
Author
|
Could I use some commands to rerun failed test? |
Member
Author
|
rerun failure checks |
dlg99
approved these changes
Feb 9, 2022
nicoloboschi
approved these changes
Feb 9, 2022
merlimat
approved these changes
Feb 9, 2022
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we get the right
authorizedstate, we need to return immediately, do not need to do an unnecessary loop.Changes
break, when get the rightauthorizedstate.