Add flaky-test template to track many flaky-test. #3035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@merlimat @eolivelli @dlg99 @nicoloboschi PTAL :) |
nicoloboschi
requested changes
Feb 10, 2022
.github/ISSUE_TEMPLATE/flaky_test.md
Outdated
| name: Flaky test | ||
| about: Report a flaky test failure | ||
| title: 'Flaky-test: test_class.test_method' | ||
| labels: ["component/test", "flaky-tests"] |
Contributor
There was a problem hiding this comment.
component/test doesn't exist. Please use area/tests. We can create the flaky-tests label @dlg99 @eolivelli
Member
Author
|
rerun failure checks |
dlg99
approved these changes
Feb 10, 2022
StevenLuMT
pushed a commit
to StevenLuMT/bookkeeper
that referenced
this pull request
Feb 16, 2022
### Motivation I found many flaky-test like apache#3031 apache#3034 apache#3033. Because many flaky tests are actually production code issues so I think it's a good way to add flaky-test template to track them ### Changes - Add flaky-test template. Reviewers: Andrey Yegorov <None> This closes apache#3035 from mattisonchao/template_flaky_test
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation I found many flaky-test like apache#3031 apache#3034 apache#3033. Because many flaky tests are actually production code issues so I think it's a good way to add flaky-test template to track them ### Changes - Add flaky-test template. Reviewers: Andrey Yegorov <None> This closes apache#3035 from mattisonchao/template_flaky_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I found many flaky-test like #3031 #3034 #3033.
Because many flaky tests are actually production code issues so I think it's a good way to add flaky-test template to track them
Changes