Skip to content

[build] make build passes on JDK17#3053

Merged
eolivelli merged 12 commits intoapache:masterfrom
nicoloboschi:build/jdk17
Apr 22, 2022
Merged

[build] make build passes on JDK17#3053
eolivelli merged 12 commits intoapache:masterfrom
nicoloboschi:build/jdk17

Conversation

@nicoloboschi
Copy link
Copy Markdown
Contributor

@nicoloboschi nicoloboschi commented Feb 16, 2022

Motivation

At the moment if you build the project with jdk17 there are a lot of crashes.

Changes

  • Upgrade of various plugins (spotbugs, shadow)
  • Lombok upgrade
  • Removed usage of java.security.AccessControlException which is deprecated for removal and it shows a warning during the build. Replaced with a BookieUnauthorizedAccessException . This could be considered a breaking change
  • Removed java.security.AccessController.doPrivileged usage in the integrations tests because is deprecated for removal

@nicoloboschi
Copy link
Copy Markdown
Contributor Author

rerun failure checks

@nicoloboschi nicoloboschi marked this pull request as ready for review March 22, 2022 16:59
@nicoloboschi
Copy link
Copy Markdown
Contributor Author

@dlg99 @eolivelli I know it's not a good moment to edit gradle files, we can merge this one after we resolve the release issue

@dlg99
Copy link
Copy Markdown
Contributor

dlg99 commented Mar 28, 2022

@nicoloboschi we need to update maven pom files too since it is back now.

@nicoloboschi
Copy link
Copy Markdown
Contributor Author

rerun failure checks

@nicoloboschi
Copy link
Copy Markdown
Contributor Author

@dlg99 @eolivelli rebased and ported changes to maven

@nicoloboschi
Copy link
Copy Markdown
Contributor Author

rerun failure checks

@nicoloboschi
Copy link
Copy Markdown
Contributor Author

@dlg99 @eolivelli @shoothzj PTAL

@nicoloboschi nicoloboschi requested review from dlg99 and eolivelli April 11, 2022 20:51
@nicoloboschi
Copy link
Copy Markdown
Contributor Author

@eolivelli @dlg99 checks passed, PTAL

Copy link
Copy Markdown
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eolivelli eolivelli merged commit f861288 into apache:master Apr 22, 2022
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants