Skip to content

BookieAutoRecoveryTest.testEmptyLedgerLosesQuorumEventually fix flaky test, ensure that the Auditor is alive #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eolivelli merged 3 commits into from
Mar 28, 2022
Merged

BookieAutoRecoveryTest.testEmptyLedgerLosesQuorumEventually fix flaky test, ensure that the Auditor is alive #3149

eolivelli merged 3 commits into from
Mar 28, 2022

Conversation

@eolivelli
Copy link
Contributor

@eolivelli eolivelli commented Mar 28, 2022 •
edited
Loading

Motivation

The test testEmptyLedgerLosesQuorumEventually kills two bookies, and very often it kills the Auditor Bookie.

Changes

  • BookKeeperClusterTestCase.getAuditor(), ensure that we pick up a Auditor that is running and that is not going to die soon
  • ReplicationWorker exits the main loop in case of InterruptedException masked by a UnavailableException (this reduces a lot the spam in the logs, because in any case the thread is deemed to always fail for InterruptedExceptions)
  • in testEmptyLedgerLosesQuorumEventually ensure that the Auditor runs and start a new Bookie before the final check (the Auditor does nothing if the is no "bookie to audit", so there are races in which if the cluster does not change the Auditor does not kick in in any case)

@eolivelli eolivelli self-assigned this Mar 28, 2022
@eolivelli eolivelli mentioned this pull request Mar 28, 2022
Merged
@eolivelli eolivelli force-pushed the tests/flaky-replication-test branch from d63ed72 to 4c8591a Compare March 28, 2022 08:23
@eolivelli eolivelli requested a review from dlg99 March 28, 2022 10:53
@eolivelli eolivelli merged commit dc2eafa into apache:master Mar 28, 2022
@eolivelli eolivelli deleted the tests/flaky-replication-test branch March 28, 2022 15:57
@equanz equanz mentioned this pull request Mar 30, 2022
Closed
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Nov 7, 2022
@eolivelli @hangc0276
BookieAutoRecoveryTest.testEmptyLedgerLosesQuorumEventually fix flaky…
a0935ef 
… test, ensure that the Auditor is alive (apache#3149)

(cherry picked from commit dc2eafa)
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Nov 7, 2022
@eolivelli @hangc0276
BookieAutoRecoveryTest.testEmptyLedgerLosesQuorumEventually fix flaky…
d4c4e21 
… test, ensure that the Auditor is alive (apache#3149)

(cherry picked from commit dc2eafa)
nicoloboschi pushed a commit to datastax/bookkeeper that referenced this pull request Jan 11, 2023
@eolivelli @nicoloboschi
BookieAutoRecoveryTest.testEmptyLedgerLosesQuorumEventually fix flaky…
12342b2 
… test, ensure that the Auditor is alive (apache#3149)

(cherry picked from commit dc2eafa)
(cherry picked from commit d4c4e21)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@eolivelli
BookieAutoRecoveryTest.testEmptyLedgerLosesQuorumEventually fix flaky…
782cb27 
… test, ensure that the Auditor is alive (apache#3149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlg99 dlg99 dlg99 approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

Assignees

@eolivelli eolivelli

Labels

area/tests cherry-picked/branch-4.14 release/4.14.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eolivelli @dlg99 @hezhangjian @nicoloboschi @hangc0276