Issue 3306: Bookie can't start after rebooting due the cookie mistmatch #3308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raúl Gracia <raul.gracia@emc.com>
eolivelli
requested review from
Ghatage,
dlg99,
hezhangjian,
merlimat and
nicoloboschi
zymap
pushed a commit
that referenced
this pull request
Aug 1, 2022
Signed-off-by: Raúl Gracia <raul.gracia@emc.com> (cherry picked from commit b477f8d)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Signed-off-by: Raúl Gracia <raul.gracia@emc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes a bug when validating the Cookie that may fail to consider a custom Bookie ID when configured.
Changes
Added custom Bookie ID when executing
possibleBookieIds()inLegacyCookieValidation. Note that this was already fixed few months back, concretely in this PR: #2796But it seems that the regression bringing back the old behavior was introduced in PR #2901.
This change may need to be cherry-picked to
branch-4.15.Master Issue: #3306
Signed-off-by: Raúl Gracia raul.gracia@emc.com