Skip to content

Bump grpcio dep version of Python client for supporting ARM #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tisonkun wants to merge 1 commit into from
Closed

Bump grpcio dep version of Python client for supporting ARM #3449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stream/clients/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
'six>=1.10.0',
'pytz',
'futures>=3.2.0;python_version<"3.2"',
'grpcio<1.28,>=1.8.2',
'grpcio>=1.37',
Copy link
Contributor

@eolivelli eolivelli Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that we have to put a cap here otherwise auto upgrades may break the client.
IIRC it happened in the past.

I I am mot sure that we have CI that is covering this change.

Copy link
Member Author

@tisonkun tisonkun Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I threw the change here to see if it breaks anything. To prepare a solid patch I need more time to understand the mechanism and see how to verify the change.

'pymmh3>=0.0.5'
]
extras = {
Expand Down