Fix group ForceWrite not take effect with forceWriteMarkerSent in while loop of ForceWriteThread #3454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equently forceWrite
Member
|
@dlg99 @zymap @hangc0276 @eolivelli have a look,thanks |
hezhangjian
approved these changes
Aug 23, 2022
codelipenghui
approved these changes
Aug 23, 2022
Contributor
codelipenghui
left a comment
codelipenghui
left a comment
There was a problem hiding this comment.
LGTM
Is it able to add a test to avoid the regression in the future?
StevenLuMT
reviewed
Aug 23, 2022
| boolean shouldForceWrite = true; | ||
| int numReqInLastForceWrite = 0; | ||
| long busyStartTime = System.nanoTime(); | ||
| boolean forceWriteMarkerSent = false; |
zymap
approved these changes
Aug 23, 2022
Member
+1 |
dlg99
approved these changes
Aug 23, 2022
Contributor
dlg99
left a comment
dlg99
left a comment
There was a problem hiding this comment.
LGTM, good catch.
Definitely needs a test.
Member
|
@zymap @eolivelli this pr can be merged, |
zymap
pushed a commit
that referenced
this pull request
Aug 24, 2022
…equently forceWrite (#3454) Fix group ForceWrite not take effect with forceWriteMarkerSent in while loop of ForceWriteThread ### Motivation Bookkeeper 4.15 has performance issue. There are too many journal sync. Then I found in ForceWriteThread, forceWriteMarkerSent is reset to false for every loop, and this can cause shouldForceWrite=true and trigger journal sync. This new logic is bringed by #2962 ### Changes move forceWriteMarkerSent=false out of while loop. (cherry picked from commit dcc9a41)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…equently forceWrite (apache#3454) Fix group ForceWrite not take effect with forceWriteMarkerSent in while loop of ForceWriteThread ### Motivation Bookkeeper 4.15 has performance issue. There are too many journal sync. Then I found in ForceWriteThread, forceWriteMarkerSent is reset to false for every loop, and this can cause shouldForceWrite=true and trigger journal sync. This new logic is bringed by apache#2962 ### Changes move forceWriteMarkerSent=false out of while loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix group ForceWrite not take effect with forceWriteMarkerSent in while loop of ForceWriteThread
Motivation
Bookkeeper 4.15 has performance issue. There are too many journal sync.
Then I found in ForceWriteThread, forceWriteMarkerSent is reset to false for every loop, and this can cause shouldForceWrite=true and trigger journal sync. This new logic is bringed by #2962
Changes
move forceWriteMarkerSent=false out of while loop.