Skip to content

fix close ledgerAuditorManager repeatedly #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zymap merged 1 commit into from
Oct 19, 2022
Merged

fix close ledgerAuditorManager repeatedly #3503

zymap merged 1 commit into from
Oct 19, 2022

Conversation

@wenbingshen
Copy link
Member

@wenbingshen wenbingshen commented Sep 26, 2022

Motivation

this introduced in #2842, the ledgerAuditorManager will be close repeatedly.

    private void submitShutdownTask() {
        executor.submit(new Runnable() {
                @Override
                public void run() {
                    if (!running.compareAndSet(true, false)) {
                        return;
                    }

                    try {
                        ledgerAuditorManager.close();   <- here has already closed LAM.
                    } catch (InterruptedException ie) {
                        Thread.currentThread().interrupt();
                        LOG.warn("InterruptedException while closing ledger auditor manager", ie);
                    } catch (Exception ke) {
                        LOG.error("Exception while closing ledger auditor manager", ke);
                    }
                }
            });
    }

@wenbingshen
Copy link
Member Author

wenbingshen commented Sep 26, 2022

ping @hangc0276 PTAL. Thanks.

@wenbingshen
Copy link
Member Author

wenbingshen commented Sep 26, 2022

rerun failure checks

StevenLuMT
StevenLuMT approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@wenbingshen
Copy link
Member Author

wenbingshen commented Sep 26, 2022

also ping @dlg99 @eolivelli @shoothzj

@zymap zymap added the type/bug label Sep 27, 2022
@zymap zymap added this to the 4.16.0 milestone Sep 27, 2022
@StevenLuMT
Copy link
Member

StevenLuMT commented Oct 6, 2022

@eolivelli @dlg99
If you have time,help review this pr,thanks

@wenbingshen
Copy link
Member Author

wenbingshen commented Oct 17, 2022

@StevenLuMT @zymap Can this PR be merged? Any more questions, please let me know. Thanks.

@wenbingshen
Copy link
Member Author

wenbingshen commented Oct 19, 2022

@zymap Can this pr be merged now. Thanks.

@zymap zymap merged commit dbec4e9 into apache:master Oct 19, 2022
@wenbingshen wenbingshen deleted the LAM_CloseRepeatedly branch October 19, 2022 06:36
zymap pushed a commit that referenced this pull request Oct 26, 2022
@wenbingshen @zymap
fix close ledgerAuditorManager repeatedly (#3503)
5a4f927 
### Motivation
this introduced in #2842, the `ledgerAuditorManager` will be close repeatedly.

```java
    private void submitShutdownTask() {
        executor.submit(new Runnable() {
                @OverRide
                public void run() {
                    if (!running.compareAndSet(true, false)) {
                        return;
                    }

                    try {
                        ledgerAuditorManager.close();   <- here has already closed LAM.
                    } catch (InterruptedException ie) {
                        Thread.currentThread().interrupt();
                        LOG.warn("InterruptedException while closing ledger auditor manager", ie);
                    } catch (Exception ke) {
                        LOG.error("Exception while closing ledger auditor manager", ke);
                    }
                }
            });
    }
```

(cherry picked from commit dbec4e9)
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Nov 7, 2022
@wenbingshen @hangc0276
fix close ledgerAuditorManager repeatedly (apache#3503)
7a496c1 
### Motivation
this introduced in apache#2842, the `ledgerAuditorManager` will be close repeatedly.

```java
    private void submitShutdownTask() {
        executor.submit(new Runnable() {
                @OverRide
                public void run() {
                    if (!running.compareAndSet(true, false)) {
                        return;
                    }

                    try {
                        ledgerAuditorManager.close();   <- here has already closed LAM.
                    } catch (InterruptedException ie) {
                        Thread.currentThread().interrupt();
                        LOG.warn("InterruptedException while closing ledger auditor manager", ie);
                    } catch (Exception ke) {
                        LOG.error("Exception while closing ledger auditor manager", ke);
                    }
                }
            });
    }
```

(cherry picked from commit dbec4e9)
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Nov 7, 2022
@wenbingshen @hangc0276
fix close ledgerAuditorManager repeatedly (apache#3503)
224254b 
### Motivation
this introduced in apache#2842, the `ledgerAuditorManager` will be close repeatedly.

```java
    private void submitShutdownTask() {
        executor.submit(new Runnable() {
                @OverRide
                public void run() {
                    if (!running.compareAndSet(true, false)) {
                        return;
                    }

                    try {
                        ledgerAuditorManager.close();   <- here has already closed LAM.
                    } catch (InterruptedException ie) {
                        Thread.currentThread().interrupt();
                        LOG.warn("InterruptedException while closing ledger auditor manager", ie);
                    } catch (Exception ke) {
                        LOG.error("Exception while closing ledger auditor manager", ke);
                    }
                }
            });
    }
```

(cherry picked from commit dbec4e9)
nicoloboschi pushed a commit to datastax/bookkeeper that referenced this pull request Jan 11, 2023
@wenbingshen @nicoloboschi
fix close ledgerAuditorManager repeatedly (apache#3503)
f6d6405 
### Motivation
this introduced in apache#2842, the `ledgerAuditorManager` will be close repeatedly.

```java
    private void submitShutdownTask() {
        executor.submit(new Runnable() {
                @OverRide
                public void run() {
                    if (!running.compareAndSet(true, false)) {
                        return;
                    }

                    try {
                        ledgerAuditorManager.close();   <- here has already closed LAM.
                    } catch (InterruptedException ie) {
                        Thread.currentThread().interrupt();
                        LOG.warn("InterruptedException while closing ledger auditor manager", ie);
                    } catch (Exception ke) {
                        LOG.error("Exception while closing ledger auditor manager", ke);
                    }
                }
            });
    }
```

(cherry picked from commit dbec4e9)
(cherry picked from commit 224254b)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@wenbingshen
fix close ledgerAuditorManager repeatedly (apache#3503)
df5d27d 
### Motivation
this introduced in apache#2842, the `ledgerAuditorManager` will be close repeatedly.

```java
    private void submitShutdownTask() {
        executor.submit(new Runnable() {
                @OverRide
                public void run() {
                    if (!running.compareAndSet(true, false)) {
                        return;
                    }

                    try {
                        ledgerAuditorManager.close();   <- here has already closed LAM.
                    } catch (InterruptedException ie) {
                        Thread.currentThread().interrupt();
                        LOG.warn("InterruptedException while closing ledger auditor manager", ie);
                    } catch (Exception ke) {
                        LOG.error("Exception while closing ledger auditor manager", ke);
                    }
                }
            });
    }
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

@zymap zymap zymap approved these changes

@StevenLuMT StevenLuMT StevenLuMT approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@dlg99 dlg99 Awaiting requested review from dlg99

@eolivelli eolivelli Awaiting requested review from eolivelli

Assignees

@wenbingshen wenbingshen

Labels

cherry-picked/branch-4.14 cherry-picked/branch-4.15 release/4.14.6 release/4.15.3 type/bug

Projects

None yet

Milestone

4.16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@wenbingshen @StevenLuMT @hangc0276 @hezhangjian @zymap