Merged
Conversation
Contributor
Author
|
@dlg99 PTAL |
hangc0276
reviewed
Oct 17, 2022
hangc0276
approved these changes
Oct 17, 2022
HQebupt
approved these changes
Oct 18, 2022
StevenLuMT
requested changes
Oct 18, 2022
Member
StevenLuMT
left a comment
StevenLuMT
left a comment
There was a problem hiding this comment.
can you add a testcase to check the right result?
StevenLuMT
reviewed
Oct 18, 2022
| EntryLogMetadata meta = entryLogger.getEntryLogMetadata(0L); | ||
| String metaString = meta.toString(); | ||
| assertEquals(metaString, | ||
| "{totalSize = 60, remainingSize = 60, ledgersMap = ConcurrentLongLongHashMap{1 => 30, 3 => 30}}"); |
StevenLuMT
approved these changes
Oct 18, 2022
Contributor
Author
|
rerun failure checks |
1 similar comment
Contributor
Author
|
rerun failure checks |
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
Fixes apache#3490 Change ToString method, print the content of map. (cherry picked from commit 5c6e78f)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
Fixes apache#3490 Change ToString method, print the content of map. (cherry picked from commit 5c6e78f)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
Fixes apache#3490 Change ToString method, print the content of map. (cherry picked from commit 5c6e78f) (cherry picked from commit 0abc039)
zymap
pushed a commit
that referenced
this pull request
Feb 16, 2023
Member
|
Branch-4.15 tests failed. I found this PR depends on PR #3256. Revert it from branch-4.15. |
zymap
added a commit
to zymap/bookkeeper
that referenced
this pull request
Feb 17, 2023
This reverts commit e05f0e0.
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Fixes apache#3490 Change ToString method, print the content of map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3490
Change
ToStringmethod, print the content of map.