-
Notifications
You must be signed in to change notification settings - Fork 962
Fix Spotbugs check failed #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
merlimat
merged 14 commits into
apache:master
from
hangc0276:chenhang/fix_spotbug_check_failed
Mar 4, 2023
Merged
Fix Spotbugs check failed #3836
merlimat
merged 14 commits into
apache:master
from
hangc0276:chenhang/fix_spotbug_check_failed
Mar 4, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2023
Closed
merlimat
approved these changes
Mar 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #3836 +/- ##
=============================================
+ Coverage 47.52% 68.32% +20.80%
- Complexity 4579 6763 +2184
=============================================
Files 473 473
Lines 40954 40950 -4
Branches 5239 5240 +1
=============================================
+ Hits 19462 27981 +8519
+ Misses 19498 10712 -8786
- Partials 1994 2257 +263
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* fix spotbugs check failed * format code * install the package first * upgrade spotbugs version to 4.7.3.2 * upgrade javadoc plugin to 3.5.0 * upgrade javadoc plugin to 3.2.0 * format code * set maven version 3.8.7 * set all test maven version to 3.8.7 * fix failed CI * add test failure * address test failure * fix failed CI * format code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Spotbugs check failed, which blocked the PRs' CI
It is caused by a maven 3.9.0: https://issues.apache.org/jira/browse/MNG-7679
However, our GitHub CI uses maven 3.9.0 by default
Modifications