Skip to content

Conversation

@hangc0276
Copy link
Contributor

@hangc0276 hangc0276 commented Mar 3, 2023

Motivation

The Spotbugs check failed, which blocked the PRs' CI

[ERROR] NullPointerException
java.lang.NullPointerException
    at org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions (MojoExecutor.java:439)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:325)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)

It is caused by a maven 3.9.0: https://issues.apache.org/jira/browse/MNG-7679

However, our GitHub CI uses maven 3.9.0 by default

Modifications

  • Fix Spotbugs check failed.
  • Set GitHub CI's maven version to 3.8.7

@hangc0276 hangc0276 self-assigned this Mar 3, 2023
@hangc0276 hangc0276 added this to the 4.16.0 milestone Mar 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #3836 (efc0674) into master (227b166) will increase coverage by 20.80%.
The diff coverage is 94.11%.

@@              Coverage Diff              @@
##             master    #3836       +/-   ##
=============================================
+ Coverage     47.52%   68.32%   +20.80%     
- Complexity     4579     6763     +2184     
=============================================
  Files           473      473               
  Lines         40954    40950        -4     
  Branches       5239     5240        +1     
=============================================
+ Hits          19462    27981     +8519     
+ Misses        19498    10712     -8786     
- Partials       1994     2257      +263     
Flag Coverage Δ
bookie 39.84% <35.29%> (?)
client 44.15% <94.11%> (?)
remaining 29.59% <52.94%> (+0.08%) ⬆️
replication 41.31% <82.35%> (-0.16%) ⬇️
tls 21.01% <35.29%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...apache/bookkeeper/client/DistributionSchedule.java 9.09% <ø> (+9.09%) ⬆️
...java/org/apache/bookkeeper/util/PageCacheUtil.java 53.12% <0.00%> (ø)
...va/org/apache/bookkeeper/client/LedgerChecker.java 81.55% <100.00%> (+3.77%) ⬆️
...ava/org/apache/bookkeeper/client/PendingAddOp.java 87.12% <100.00%> (+24.02%) ⬆️
...rg/apache/bookkeeper/client/PendingWriteLacOp.java 73.17% <100.00%> (+73.17%) ⬆️
...kkeeper/client/RoundRobinDistributionSchedule.java 84.73% <100.00%> (+32.86%) ⬆️
...keeper/replication/AuditorCheckAllLedgersTask.java 53.74% <0.00%> (-4.09%) ⬇️
...va/org/apache/bookkeeper/versioning/Versioned.java 75.00% <0.00%> (ø)
...org/apache/bookkeeper/client/BookieInfoReader.java 70.81% <0.00%> (ø)
...apache/bookkeeper/meta/ZkLedgerAuditorManager.java 71.69% <0.00%> (ø)
... and 236 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@merlimat merlimat merged commit b4112df into apache:master Mar 4, 2023
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
* fix spotbugs check failed

* format code

* install the package first

* upgrade spotbugs version to 4.7.3.2

* upgrade javadoc plugin to 3.5.0

* upgrade javadoc plugin to 3.2.0

* format code

* set maven version 3.8.7

* set all test maven version to 3.8.7

* fix failed CI

* add test failure

* address test failure

* fix failed CI

* format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants