Fix write entry failed in without writing journal case #3884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Mar 24, 2023
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Great catch
It's weird that no test failed!
Contributor
Author
|
@merlimat @eolivelli @zymap @horizonzy Please help take a look at this fix, and it is a blocker for BookKeeper 4.16.0 release. |
Contributor
Author
@eolivelli I found no tests covered this case. |
15 tasks
hangc0276
added a commit
that referenced
this pull request
Mar 26, 2023
### Motivation #3837 introduced group flush add responses triggered by journal sync. However, if we skip writing journals, the add responses won't be flushed to the netty channel and the client will receive write entries timeout. ### Changes - Flush the add responses when skipping writing journals - Add tests to cover V2 protocol and skip writing journal cases. (cherry picked from commit 5deadcc)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation apache#3837 introduced group flush add responses triggered by journal sync. However, if we skip writing journals, the add responses won't be flushed to the netty channel and the client will receive write entries timeout. ### Changes - Flush the add responses when skipping writing journals - Add tests to cover V2 protocol and skip writing journal cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#3837 introduced group flush add responses triggered by journal sync. However, if we skip writing journals, the add responses won't be flushed to the netty channel and the client will receive write entries timeout.
Changes