Skip to content

Conversation

@gaozhangmin
Copy link
Contributor

Motivation

Before #3848,Bookie sent response by org.apache.bookkeeper.proto.PacketProcessorBase#sendResponse
And we record the add request stat in this method.

if (BookieProtocol.EOK == rc) {
            statsLogger.registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
        } else {
            statsLogger.registerFailedEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);
        }

Now, we implement an new flush strategy, and missed record add request stat.

Changes

Record add request stat in writeComplete

Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This metric doesn't include the response that is queued in the flush queue. More context: https://apache-pulsar.slack.com/archives/C052JAH3W7N/p1682391400854209?thread_ts=1682343363.198299&cid=C052JAH3W7N

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants