Use mockito instead of powermock #4212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
use-mockit-instead-of-powermock
branch
5 times, most recently
from
6a0dc1b to
ecd2c20
Compare
nodece
force-pushed
the
use-mockit-instead-of-powermock
branch
from
ecd2c20 to
b1179da
Compare
merlimat
approved these changes
Feb 20, 2024
Member
|
Great job @nodece |
Member
|
@nodece the next step would be to upgrade Mockito to 4.11. That's the last version that supports Java 8. Would you like to handle it. There are some minor breaking changes in Mockito between 3.x -> 4.x. the upgrade PR in Pulsar could be a useful reference |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4201
Motivation
PowerMock is no longer maintained. The last release way in January 2020.
Changes