BROOKLYN-323: Use proper WWW-Authorization header in karaf#578
Merged
asfgit merged 1 commit intoapache:masterfrom Mar 6, 2017
Merged
BROOKLYN-323: Use proper WWW-Authorization header in karaf#578asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
bostko
commented
Mar 2, 2017
| <bean class="org.apache.brooklyn.rest.util.FormMapProvider"/> | ||
| <bean class="org.apache.cxf.jaxrs.security.JAASAuthenticationFilter"> | ||
| <property name="contextName" value="webconsole"/> | ||
| <property name="realmName" value="webconsole"/> |
Contributor
Author
There was a problem hiding this comment.
This sets proper WWW-Authorization: Basic realm="something"
bostko
changed the title
Contributor
|
@bostko looks good. Will test and merge if ok. |
Contributor
|
I'll leave this while brooklyn-ui#36 is still open. |
Contributor
Author
|
This PR is not dependent brooklyn-ui#36. |
- Give valid WWW-Authorization header to the client. Previously it was just WWW-Authorization: Basic Where it has to be WWW-Authorization: Basic realm="something" - LogoutApi#unAuthorize method useful for making browsers forget Basic Authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was just WWW-Authorization: Basic
Where it has to be WWW-Authorization: Basic realm="something" That was major Chrome complain for dissrespecting that header.
This PR should be reviewed and merged together with apache/brooklyn-ui#36