Modular catalog.bom#834
Merged
asfgit merged 2 commits intoapache:masterfrom Sep 29, 2017
Merged
Conversation
This was referenced Sep 20, 2017
tbouron
force-pushed
the
update/reuse-bom
branch
2 times, most recently
from
90056af to
a3959d1
Compare
Contributor
Contributor
|
#842 is merged so simply merging master in to this should fix things without too much irritation |
tbouron
force-pushed
the
update/reuse-bom
branch
from
a3959d1 to
dc82022
Compare
Member
Author
|
Indeed, just rebased on latest master @ahgittin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE: This is based on #842 for the
mvn:syntax to workThis reuses each bundle's
catalog.bomfile to build globalcatalog.bom. It replaceskaraf/init/src/main/resources/catalog-classes.bombykaraf/init/src/main/resources/catalog.bomIt avoids the duplication of bom files and keep all the metadata (title, description, iconUrl, etc) under the same module that contains the actual Java entity.
Those changes spans across
brooklyn-server,brooklyn-libraryandbrooklyn-dist. To be tested with: