Fix Acceptor::BeforeRecycle during Accept::StartAccept dead lock #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesge
reviewed
Jun 14, 2022
| } | ||
|
|
||
| int Socket::SetFailedOnCreate(int error_code, const char* error_text) { | ||
| _user = NULL; // Avoid calling _user->BeforeRecycle() which may cause dead lock or double free |
Contributor
There was a problem hiding this comment.
这个是不是可以反过来在BeforeRecycle前判一下rpc failed?
Contributor
Author
There was a problem hiding this comment.
这里主要是为了区分是在Create Socket过程中出错，还是使用Socket过程中出错
回调BeforeRecycle的时候，Socket已经是Failed的状态了，似乎难以区分是不是Create Socket的过程
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1772