Test cases for [CALCITE-6299] Support JOIN in Arrow adapter#4908
Open
xuzifu666 wants to merge 1 commit intoapache:mainfrom
Open
Test cases for [CALCITE-6299] Support JOIN in Arrow adapter#4908xuzifu666 wants to merge 1 commit intoapache:mainfrom
xuzifu666 wants to merge 1 commit intoapache:mainfrom
Conversation
mihaibudiu
reviewed
Apr 24, 2026
| .with(arrow) | ||
| .query(sql) | ||
| .limit(1) | ||
| .limit(6) |
Contributor
There was a problem hiding this comment.
why do you need a limit?
Member
Author
There was a problem hiding this comment.
The output was long, so I used a limit, but limit shouldn't be needed here. I removed limit in test case accordingly.
mihaibudiu
approved these changes
Apr 25, 2026
| + " ArrowToEnumerableConverter\n" | ||
| + " ArrowProject(intField=[$0])\n" | ||
| + " ArrowTableScan(table=[[ARROW, ARROWDATA]], fields=[[0, 1, 2, 3]])\n\n"; | ||
| String result = "intField=0; intField=0\n" |
Contributor
There was a problem hiding this comment.
This is very regular, could be generated by a loop
Member
Author
There was a problem hiding this comment.
Yes, had changed in a loop.
|
xuzifu666
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-6299
Since
ArrowTablealready holdsArrowFileReaderand has undergone some recent Arrow Adapter changes, the Arrow Adapter now supports JOIN. This PR supplements and enhances the relevant tests.