Add self-only policy methods for watcher synchronization without adapter calls#516
Closed
Add self-only policy methods for watcher synchronization without adapter calls#516
Conversation
|
|
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
…ait from removePolicy Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add methods to enforcer for policy management
Add self-only policy methods for watcher synchronization without adapter calls
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In microservice architectures using watchers with MongoDB adapters, updating policies in watcher callbacks triggers duplicate database writes and infinite update loops. When microservice A adds a policy, the watcher notifies B and C. If B and C use
addPolicy()in their callbacks, they write to MongoDB again and trigger more watcher updates.Changes
Internal methods (
InternalEnforcer)*Self()methods that modify in-memory policy only:addPolicySelf,addPoliciesSelf,updatePolicySelf,removePolicySelf,removePoliciesSelf,removeFilteredPolicySelfautoSavesettingautoNotifyWatchersettingPublic API (
ManagementEnforcer)self*methods matching existing policy API surfaceselfAddPolicy,selfAddPolicies,selfUpdatePolicy,selfRemovePolicy, etc.selfAddGroupingPolicy,selfAddGroupingPolicies,selfUpdateGroupingPolicy, etc.Usage
Testing
Added 28 tests verifying adapter and watcher methods are not invoked when
autoSave=trueandautoNotifyWatcher=true.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.