Skip to content

PYTHON-1354 do not set timeout to None when calling execute_async in execute_concurrent #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osttra-h-jarrendal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PYTHON-1354 do not set timeout to None when calling execute_async in execute_concurrent #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cassandra/concurrent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def _execute_next(self):
def _execute(self, idx, statement, params):
self._exec_depth += 1
try:
future = self.session.execute_async(statement, params, timeout=None, execution_profile=self._execution_profile)
future = self.session.execute_async(statement, params, execution_profile=self._execution_profile)
Copy link
Contributor

@absurdfarce absurdfarce Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the analysis here. execute_async() has a default value for the timeout param which results in the default timeout being used as long as no override is supplied (here by way of this call). Code path in _create_response_future() is slightly different when execution contexts are in play but the same analysis seems to hold.

args = (future, idx)
future.add_callbacks(
callback=self._on_success, callback_args=args,
Expand Down