[CELEBORN-1466] Add local command in celeborn_ratis_shell.md #2575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1466
branch
from
fc3fe02 to
4f8162a
Compare
Member
Author
|
Ping @FMX, @AngersZhuuuu. |
FMX
approved these changes
Jun 19, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Merged into main(v0.6.0), branch-0.5(v0.5.1).
FMX
pushed a commit
that referenced
this pull request
Jun 19, 2024
### What changes were proposed in this pull request? Add `local` command in `celeborn_ratis_shell.md` to sync document [cli.md](https://github.com/apache/ratis/blob/ratis-3.0.1/ratis-docs/src/site/markdown/cli.md). ### Why are the changes needed? Celeborn has already bumped Ratis version from 2.5.1 to 3.0.1. Ratis v3.0.1 supports `local` command to process local operation, which no need to connect to ratis server. `celeborn_ratis_shell.md` should add local command to guide users to process local operation. Backport: apache/ratis#901 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No. Closes #2575 from SteNicholas/CELEBORN-1466. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com> (cherry picked from commit e4d3b80) Signed-off-by: mingji <fengmingxiao.fmx@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
localcommand inceleborn_ratis_shell.mdto sync document cli.md.Why are the changes needed?
Celeborn has already bumped Ratis version from 2.5.1 to 3.0.1. Ratis v3.0.1 supports
localcommand to process local operation, which no need to connect to ratis server.celeborn_ratis_shell.mdshould add local command to guide users to process local operation.Backport: apache/ratis#901
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.