Skip to content

Partially revert 48302989 to fix pxf_regress#87

Merged
ostinru merged 2 commits intoapache:mainfrom
ostinru:strict-regress-tests-v2
Mar 27, 2026
Merged

Partially revert 48302989 to fix pxf_regress#87
ostinru merged 2 commits intoapache:mainfrom
ostinru:strict-regress-tests-v2

Conversation

@ostinru
Copy link
Copy Markdown
Collaborator

@ostinru ostinru commented Mar 26, 2026

In this PR:

  • revert changes from 4830298 to fix regression: pxf_regress will agian rise an error when diff is found
  • mark broken tests with enabled = false and TODO comment

Fixes #86

@ostinru ostinru marked this pull request as ready for review March 26, 2026 10:01
@MisterRaindrop
Copy link
Copy Markdown
Collaborator

There is no tracking issue to ensure these tests will be fixed later, making them easy to forget. Should we record them in an issue to avoid forgetting?

@ostinru
Copy link
Copy Markdown
Collaborator Author

ostinru commented Mar 26, 2026

There is no tracking issue to ensure these tests will be fixed later, making them easy to forget. Should we record them in an issue to avoid forgetting?

Left it here as checklist: #86 (comment)

@ostinru ostinru merged commit 55165b1 into apache:main Mar 27, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pxf_regress is broken need fix it

2 participants