Loosen the restriction outer path has Motion of parallel plan#134
Merged
avamingli merged 1 commit intoapache:mainfrom Aug 24, 2023
Merged
Loosen the restriction outer path has Motion of parallel plan#134avamingli merged 1 commit intoapache:mainfrom
avamingli merged 1 commit intoapache:mainfrom
Conversation
cd9a475 to
aa86ba9
Compare
Contributor
Author
|
This causes SemiJoin plan diffs, need to dig. |
We drop all outer paths who have Motion of parallel plan to avoid
deadlock when mixing parallel-aware hashjoin with parallel-oblivious
paths.
And we fix it to enable_parallel, which is stricter than needed.
It's possible to keep such a path when enable_parallel is on and
enable_parallel_hash is off.
Because we can make sure that there is no parallel-aware hashjoin,
and of course, no deadlock issues like above.
By loosening the restriction to enable_parallel_hash, such parallel
-oblivious plan would be possible.
explain(costs off) select * from t1 right join t2 on t1.b = t2.a;
QUERY PLAN
------------------------------------------------------------------
Gather Motion 6:1 (slice1; segments: 6)
-> Hash Left Join
Hash Cond: (t2.a = t1.b)
-> Redistribute Motion 6:6 (slice2; segments: 6)
Hash Key: t2.a
Hash Module: 3
-> Parallel Seq Scan on t2
-> Hash
-> Redistribute Motion 3:6 (slice3; segments: 3)
Hash Key: t1.b
Hash Module: 3
-> Seq Scan on t1
Optimizer: Postgres query optimizer
(13 rows)
Authored-by: Zhang Mingli avamingli@gmail.com
aa86ba9 to
74aa5c7
Compare
Contributor
Author
Fixed. |
my-ship-it
approved these changes
Aug 24, 2023
yjhjstz
reviewed
Aug 24, 2023
yjhjstz
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We drop all outer paths who have Motion of parallel plan to avoid deadlock when mix parallel-aware hashjoin with parallel-oblivious paths.
And we fix it to enable_parallel, which is stricter than needed.
It's possible to keep such a path when enable_parallel is on and enable_parallel_hash is off.
Because we can make sure that there is no parallel-aware hashjoin, and of course, no deadlock issue like above.
By loosening the restriction to enable_parallel_hash, such parallel-oblivious plan would be possible.
Before this change, we could only get a non-parallel plan when
enable_parallel=onandenable_parallel_hash=offAuthored-by: Zhang Mingli avamingli@gmail.com
closes: #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel