Skip to content

Fix compilation with --disable-orca#1342

Merged
yjhjstz merged 1 commit intoapache:mainfrom
yjhjstz:yjh/fix_orca_c
Sep 5, 2025
Merged

Fix compilation with --disable-orca#1342
yjhjstz merged 1 commit intoapache:mainfrom
yjhjstz:yjh/fix_orca_c

Conversation

@yjhjstz
Copy link
Copy Markdown
Member

@yjhjstz yjhjstz commented Sep 2, 2025

Remove the USE_ORCA ifdef around OptimizerOptions. The struct is required regardless of ORCA support, and the conditional caused compilation failures when configured with --disable-orca.

Fixes #1329

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


Copy link
Copy Markdown
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove the USE_ORCA ifdef around OptimizerOptions. The struct is
required regardless of ORCA support, and the conditional caused
compilation failures when configured with --disable-orca.
@yjhjstz yjhjstz merged commit 19720e8 into apache:main Sep 5, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation fails when ORCA optimizer is disabled with --disable-orca flag

3 participants