Fix create ao table set parallel_workers doesn't take effect#168
Merged
my-ship-it merged 1 commit intoapache:mainfrom Sep 1, 2023
Merged
Fix create ao table set parallel_workers doesn't take effect#168my-ship-it merged 1 commit intoapache:mainfrom
my-ship-it merged 1 commit intoapache:mainfrom
Conversation
Contributor
|
add a test case? |
Contributor
Author
|
A test case has been added. I've verified that before this fix the test would fail. |
yjhjstz
reviewed
Aug 31, 2023
"create table ao(c int) using ao_row with(parallel_workers=3)" doesn't take effect because only storage options are taken care of in reloptions_gp.c:transformAOStdRdOptions. This PR fixes this by add code processing parallel_workers.
yjhjstz
approved these changes
Aug 31, 2023
avamingli
approved these changes
Aug 31, 2023
baotingfang
pushed a commit
that referenced
this pull request
Dec 1, 2023
"create table ao(c int) using ao_row with(parallel_workers=3)" doesn't take effect because only storage options are taken care of in reloptions_gp.c:transformAOStdRdOptions. This PR fixes this by add code processing parallel_workers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #131
Change logs
create table ao(c int) using ao_row with(parallel_workers=3)doesn't take effect because only storage options are taken care of inreloptions_gp.c:transformAOStdRdOptions. This PR fixes this by add code processingparallel_workers.The default value of
parallel_workers(-1) is taken fromreloptions.c:intRelOpts. There're no#define-ed constant forparallel_workers's name and default value so I hard-coded them.transformAOStdRdOptionsactually readsWITHclauses before readsStdRdOptions. In the comment they say this is to preserve the order of options because some tests rely on it. I take the value fromStdRdOptionsw/o examiningWITHclause and I see no necessity in doing so. Don't know if this could go wrong :-/Does this PR introduce any user-facing change?
Yes. It fixes a user-perceptible bug.