Skip to content

Doc: update the building guide for Linux#170

Merged
my-ship-it merged 1 commit intoapache:mainfrom
Baowen648:main
Sep 5, 2023
Merged

Doc: update the building guide for Linux#170
my-ship-it merged 1 commit intoapache:mainfrom
Baowen648:main

Conversation

@Baowen648
Copy link
Copy Markdown
Contributor

closes: #ISSUE_Number


Change logs

Since the previous document is a legacy document, much of the code may be invalid, so we verified and tidied it up. The accuracy of the document is ensured, which is easy for users to read, and the environment can be quickly built according to the document.

Why are the changes needed?

Ensure that the documentation is accurate and usable

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

According to the documents needed by the users can quickly build on Linux environment

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 31, 2023

CLA assistant check
All committers have signed the CLA.

@Baowen648
Copy link
Copy Markdown
Contributor Author

PR has been generated, please help me have a look at what's the problem, thank you@tuhaihe @tuhaihe

@tuhaihe tuhaihe self-requested a review August 31, 2023 06:34
Comment thread readmes/README.Linux.md Outdated
@tuhaihe
Copy link
Copy Markdown
Member

tuhaihe commented Aug 31, 2023

Hi @Zhangbaowen-Hashdata: Thanks for your contribution. Please squash your commits down to one before this PR is merged. Maybe you can take our coding guide as a reference.

@Baowen648 Baowen648 force-pushed the main branch 2 times, most recently from cf6c82d to 2dbc18d Compare August 31, 2023 10:38
Comment thread readmes/README.Linux.md Outdated
Copy link
Copy Markdown
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuhaihe LGTM.

Copy link
Copy Markdown
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Since the previous document is a legacy document, much of the code
may be invalid, so we verified and tidied it up. The accuracy of
the document is ensured, which is easy for users to read, and the
environment can be quickly built according to the document.
@tuhaihe
Copy link
Copy Markdown
Member

tuhaihe commented Sep 4, 2023

Hi @baotingfang @my-ship-it, please help review this PR, thanks.

Copy link
Copy Markdown
Contributor

@baotingfang baotingfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it
Copy link
Copy Markdown
Contributor

LGTM

@my-ship-it my-ship-it merged commit ce793ba into apache:main Sep 5, 2023
baotingfang pushed a commit that referenced this pull request Dec 1, 2023
Since the previous document is a legacy document, much of the code
may be invalid, so we verified and tidied it up. The accuracy of
the document is ensured, which is easy for users to read, and the
environment can be quickly built according to the document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants