Skip to content

Limit CI concurrency to one per PR, redux#261

Closed
Ray-Eldath wants to merge 1 commit intoapache:mainfrom
Ray-Eldath:revert-258-revert-233-ci-concurrency
Closed

Limit CI concurrency to one per PR, redux#261
Ray-Eldath wants to merge 1 commit intoapache:mainfrom
Ray-Eldath:revert-258-revert-233-ci-concurrency

Conversation

@Ray-Eldath
Copy link
Copy Markdown
Contributor

@Ray-Eldath Ray-Eldath commented Oct 24, 2023

This PR should only be merged after CI pipeline considered stable again.
This PR reverts #258.


In current workflow, when newer commit comes, old pipeline won't get canceled, which wastes resources and cause unnecessary CI failure emails. This PR limits concurrency to one per PR. when newer commit comes, stale CI jobs will be automatically cancelled.

See: https://stackoverflow.com/a/72408109/8711684

@Ray-Eldath Ray-Eldath force-pushed the revert-258-revert-233-ci-concurrency branch from e3e1625 to 0881a53 Compare October 24, 2023 08:09
@Ray-Eldath Ray-Eldath changed the title Limit CI concurrency to one per PR Limit CI concurrency to one per PR, redux Oct 24, 2023
@Ray-Eldath Ray-Eldath marked this pull request as ready for review October 26, 2023 01:51
@my-ship-it my-ship-it self-requested a review November 3, 2023 09:13
Copy link
Copy Markdown
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ray-Eldath Ray-Eldath force-pushed the revert-258-revert-233-ci-concurrency branch from 0881a53 to a3884f3 Compare November 3, 2023 09:52
This reverts commit 6fa22ec.
Revert "Revert "Limit CI concurrency to one per PR""

In current workflow, when newer commit comes, old pipeline won't get
canceled, which wastes resources and cause unnecessary CI failure
emails. This PR limits concurrency to one per PR. when newer
commit comes, stale CI jobs will be automatically cancelled.

See: https://stackoverflow.com/a/72408109/8711684
See: apache#258
@my-ship-it my-ship-it force-pushed the revert-258-revert-233-ci-concurrency branch from a3884f3 to 5190f9d Compare November 9, 2023 07:29
@my-ship-it
Copy link
Copy Markdown
Contributor

Close the PR since no response for a long time

@my-ship-it my-ship-it closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants