Rename 'Parallel Broadcast Motion' to 'Broadcast Workers Motion'#265
Merged
my-ship-it merged 1 commit intoapache:mainfrom Nov 7, 2023
Merged
Rename 'Parallel Broadcast Motion' to 'Broadcast Workers Motion'#265my-ship-it merged 1 commit intoapache:mainfrom
my-ship-it merged 1 commit intoapache:mainfrom
Conversation
A Parallel node in plan means it's a parallel aware node. Parallel Seq Scan: workers work together to scan a table, Parallel Hash Join: workers work together to make a join. And in the internal implementation, a Parallel node usually has a technique(shared memory) to sync between workers. It's confused for Parallel Broadcast Motion, the workers of this node doesn't use such a technique to sync. The node is not parallel aware, and the real meaning is to send tuples across target slice's workers for each segment. Let's rename it to Broadcast Workers Motion representing for broadcasting tuples across workers of segments. Authored-by: Zhang Mingli avamingli@gmail.com
baotingfang
pushed a commit
that referenced
this pull request
Dec 1, 2023
A Parallel node in plan means it's a parallel aware node. Parallel Seq Scan: workers work together to scan a table, Parallel Hash Join: workers work together to make a join. And in the internal implementation, a Parallel node usually has a technique(shared memory) to sync between workers. It's confused for Parallel Broadcast Motion, the workers of this node doesn't use such a technique to sync. The node is not parallel aware, and the real meaning is to send tuples across target slice's workers for each segment. Let's rename it to Broadcast Workers Motion representing for broadcasting tuples across workers of segments. Authored-by: Zhang Mingli avamingli@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Parallel node in plan means it's a parallel aware node.
Parallel Seq Scan: workers work together to scan a table,
Parallel Hash Join: workers work together to make a join.
And in the internal implementation, a Parallel node usually has a technique(shared memory) to sync between workers.
It's confused for Parallel Broadcast Motion, the workers of this node doesn't use such a technique to sync.
The node is not parallel aware, and the real meaning is to send tuples across target slice's workers for each segment.
Let's rename it to Broadcast Workers Motion representing for broadcasting tuples across workers of segments.
Authored-by: Zhang Mingli avamingli@gmail.com
closes: #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel