Skip to content

Fix: may cause UAF problem in get_size_from_segDBs #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avamingli merged 2 commits into from
Dec 11, 2023
Merged

Fix: may cause UAF problem in get_size_from_segDBs #326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0924717
Fix: may cause UAF problem in get_size_from_segDBs
jiaqizho Dec 7, 2023
92503be
Merge branch 'main' into fix-uaf-in-udf-get-size-from-segs
jiaqizho Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/backend/utils/adt/dbsize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,21 +89,30 @@ get_size_from_segDBs(const char *cmd)
for (i = 0; i < cdb_pgresults.numResults; i++)
{
Datum value;
ExecStatusType status;
int ntuples;
int nfields;

struct pg_result *pgresult = cdb_pgresults.pg_results[i];

if (PQresultStatus(pgresult) != PGRES_TUPLES_OK)
status = PQresultStatus(pgresult);
if (status != PGRES_TUPLES_OK)
{
cdbdisp_clearCdbPgResults(&cdb_pgresults);
ereport(ERROR,
(errmsg("unexpected result from segment: %d",
PQresultStatus(pgresult))));
status)));
}
Comment thread
avamingli marked this conversation as resolved.
if (PQntuples(pgresult) != 1 || PQnfields(pgresult) != 1)

ntuples = PQntuples(pgresult);
nfields = PQnfields(pgresult);

if (ntuples != 1 || nfields != 1)
{
cdbdisp_clearCdbPgResults(&cdb_pgresults);
ereport(ERROR,
(errmsg("unexpected shape of result from segment (%d rows, %d cols)",
PQntuples(pgresult), PQnfields(pgresult))));
ntuples, nfields)));
}
if (PQgetisnull(pgresult, 0, 0))
value = 0;
Expand Down